feat: Semconv Span Helpers #1758
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielvalentin
force-pushed
the
http-helpers
branch
from
f0aec5e to
36b7dcd
Compare
arielvalentin
requested review from
a team,
ahayworth,
dazuma,
ericmustin,
fbogsany,
kaylareopelle,
mwear,
plantfansam,
robbkidd,
robertlaurin,
simi and
xuan-cao-swi
as code owners
Contributor
Author
|
@hannahramadan I have given some thought to what we discussed in the SIG. I have decided that I am going to close this for now and refactor my way into what the final state will look like. I am going to introduce some structural (and knowledge) duplication in all of the HTTP instrumentations and then work my way backwards to see what is best to extract into the semconv gem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a helper gem for use in instrumentations that will standardize semantic convention naming.
The initial implementation adds an implementation for HTTP Client span names: https://opentelemetry.io/docs/specs/semconv/http/http-spans/#name
The usage of this helper is intended to replace uses in all client gems (excon, http, net-http, etc...). This will allow wrapper libraries to enrich span names without the need for custom code and reuse the existing HTTP ClientContext helper.